Hi Tyler, Eduardo, On 24/02/2015 20:56, Tyler Hall wrote: > Eduardo, > > On Tue, Feb 24, 2015 at 1:36 PM, Eduardo Valentin <edubezval@xxxxxxxxx> wrote: >> The fix seams reasonable. Although, it remains the question what is >> applicability to other Armada chips? Besides, shouldn't we simply use it >> by default? Also, do you plan to send updates in the DTS files? > > As far as I can tell, Armada 370 is already using the equivalent of > this register I'd like to use in Armada XP. I'm not sure about the > other mvebu platforms. I couldn't just change the device tree for XP > to instantiate the 370 sensor, however, as they have different > initialization routines. Possibly Eziquiel can comment on the > significance of the differences between armadaxp_init_sensor() and > armada370_init_sensor(). > > I would like to change the default going forward, but I don't think it > can be changed on platforms using an older DTB. Here you introduced a new kind of thermal sensor, at least from the point of view of the device tree. You used a new compatible string associated to a different register. By using it by default do you mean removing marvell,armadaxp-thermal and adding armadaxp-filtered-thermal instead ? Does that new thermal sensors only improve the stability or does it also modify the value? In the second case it will more or less break the user space expectation. > > I had planned to submit the dts change separately. It's not clear to > me how that's supposed to be handled if they might go through > different trees. For this, there is no problem be handled in a different tree. At the end we will need both the a new dts and a new driver to use it, so the fact that the dts or the driver patch is merged in mainline first is not important. Thanks, Gregory > > Thanks, > Tyler > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
