On 5/28/24 07:26, Conor Dooley wrote:
On Tue, May 28, 2024 at 06:21:21PM +0530, Naresh Solanki wrote:
Add Devicetree binding documentation for Maxim MAX6639 temperature
monitor with PWM fan-speed controller.
Other than unneeded |s where your descriptions don't have any
formatting, this patch looks fine. That said - where's your dts or your
driver? A binding on its own is unusual.
The driver is drivers/hwmon/max6639.c which needs other unrelated changes/
cleanups. Holding those up until the bindings are accepted would not make
sense, so my guess is that Naresh decided to pursue the other changes for now
and add devicetree support to the driver after the devicetree properties
have been approved. On the other side, adding devicetree support does depend
on the other changes, so trying to do that before the other changes are
complete would be difficult.
That is just my guess, though, and I am ok with it.
Thanks,
Guenter
