On Wed, Feb 25, 2015 at 7:36 AM, Peter Griffin <peter.griffin@xxxxxxxxxx> wrote: > The example is wrong in that the phys property should take a > phandle to the phy port. > > Also with the changing over to generic PHY type constants we also > update this as well. > > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx> We seem to have a variety of ways to describe phy's with SATA controllers. Some consistency would have been nice. However, as this is a doc correction: Acked-by: Rob Herring <robh@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/ata/ahci-st.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ata/ahci-st.txt b/Documentation/devicetree/bindings/ata/ahci-st.txt > index 0574a77..1331202 100644 > --- a/Documentation/devicetree/bindings/ata/ahci-st.txt > +++ b/Documentation/devicetree/bindings/ata/ahci-st.txt > @@ -11,7 +11,7 @@ Required properties: > - reset-names : Associated names must be; "pwr-dwn" and "sw-rst" > - clocks : The phandle for the clock > - clock-names : Associated name must be; "ahci_clk" > - - phys : The phandle for the PHY device > + - phys : The phandle for the PHY port > - phy-names : Associated name must be; "ahci_phy" > > Example: > @@ -21,7 +21,7 @@ Example: > reg = <0xfe380000 0x1000>; > interrupts = <GIC_SPI 157 IRQ_TYPE_NONE>; > interrupt-names = "hostc"; > - phys = <&miphy365x_phy MIPHY_PORT_0 MIPHY_TYPE_SATA>; > + phys = <&phy_port0 PHY_TYPE_SATA>; > phy-names = "ahci_phy"; > resets = <&powerdown STIH416_SATA0_POWERDOWN>, > <&softreset STIH416_SATA0_SOFTRESET>; > -- > 1.9.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
