On Mon, May 27, 2024 at 05:40:03PM +0200, Philipp Zabel wrote: > Hi Dmitry, > > On Mi, 2024-04-17 at 00:58 +0300, Dmitry Baryshkov wrote: > > On Sun, Mar 31, 2024 at 11:28:57PM +0300, Dmitry Baryshkov wrote: > > > The IPUv3 DRM i.MX driver contains several codepaths for different > > > usescases: both LDB and paralllel-display drivers handle next-bridge, > > > panel and the legacy display-timings DT node on their own. > > > > > > Drop unused ddc-i2c-bus and edid handling (none of the DT files merged > > > upstream ever used these features), switch to panel-bridge driver, > > > removing the need to handle drm_panel codepaths separately and finally > > > switch to drm_bridge_connector, removing requirement for the downstream > > > bridges to create drm_connector on their own. > > > > > > This has been tested on the iMX53 with the DPI panel attached to LDB via > > > LVDS decoder, using all possible usecases (lvds-codec + panel, panel > > > linked directly to LDB node and the display-timings node). > > > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > --- > > > Changes in v2: > > > - Fixed drm_bridge_attach flags in imx/parallel-display driver. > > > - Moved the legacy bridge to drivers/gpu/drm/bridge > > > - Added missing EXPORT_SYMBOL_GPL to the iMX legacy bridge > > > - Link to v1: https://lore.kernel.org/r/20240311-drm-imx-cleanup-v1-0-e104f05caa51@xxxxxxxxxx > > > > Phillip, Shawn, Sascha, any comments on this patchset? > > Sorry for the delay, this all looks sane to me. I can't find any users > of the "edid" and "ddc-i2c-bus" properties either. But let me test on > i.MX6 and with parallel-display as well. At some point Chris dropped me a note that he had issues with i.MX5 / sii902x driver, but because of the Connect I wasn't able to fully triage it. I hope to have time this week. -- With best wishes Dmitry
