Re: [PATCH] dt-bindings: watchdog: img,pdc-wdt: Convert to dtschema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/05/2024 08:21, Shresth Prasad wrote:
> Convert txt bindings of ImgTec's PDC watchdog timer to dtschema to allow
> for validation.
> 
> Signed-off-by: Shresth Prasad <shresthprasad7@xxxxxxxxx>
> ---
> The binding has been checked and tested against `img/pistachio_marduk.dts`
> with no errors or warnings.
> ---


Thank you for your patch. There is something to discuss/improve.


> +
> +maintainers:
> +  - Shresth Prasad <shresthprasad7@xxxxxxxxx>
> +
> +

Just one blank line.

> +allOf:
> +  - $ref: watchdog.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - img,pdc-wdt
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 2

Instead of maxItems please list items with description so the items will
be described.

> +
> +  clock-names:
> +    items:
> +      - const: wdt
> +      - const: sys
> +
> +  interrupts:
> +    description:
> +      Should contain WDT interrupt

Drop description, redundant.

> +    maxItems: 1
> +
> +  assigned-clocks:
> +    maxItems: 2

Drop property

> +
> +  assigned-clock-rates:
> +    maxItems: 2

Drop property

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - interrupts
> +
Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux