Hi Conor, Thanks for your feedback. On 2024-05-27 17:36:23 +0100, Conor Dooley wrote: > On Mon, May 27, 2024 at 03:19:45PM +0200, Niklas Söderlund wrote: > > Document support for the ISP module in the Renesas V4M (r8a779h0) SoC. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > > Should be with: > https://lore.kernel.org/all/20240527132513.1684232-1-niklas.soderlund+renesas@xxxxxxxxxxxx/ I posted the bindings separate from the driver with the intention that once they are accepted I can upstream the driver and the DT for the device using it in parallel. The V4L2 subsystem is at times overloaded and in the past waiting for both driver and binding to be accepted as a whole unit have delayed entablement of SoC features unneeded for one or more releases. > > No mention of why this can't just fall back to an existing device here > or in the driver. Why not? For better or worse that is how all Renesas devices are handled, one new device compatible for each device. This have worked well as each device usually have a quirk or extra future that is enabled later. > > > --- > > Documentation/devicetree/bindings/media/renesas,isp.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/media/renesas,isp.yaml b/Documentation/devicetree/bindings/media/renesas,isp.yaml > > index 33650a1ea034..d335d5595429 100644 > > --- a/Documentation/devicetree/bindings/media/renesas,isp.yaml > > +++ b/Documentation/devicetree/bindings/media/renesas,isp.yaml > > @@ -22,6 +22,7 @@ properties: > > - enum: > > - renesas,r8a779a0-isp # V3U > > - renesas,r8a779g0-isp # V4H > > + - renesas,r8a779h0-isp # V4M > > reg: > > maxItems: 1 > > > > -- > > 2.45.1 > > -- Kind Regards, Niklas Söderlund
