On Mon, May 27, 2024 at 10:48:12AM +0200, Neil Armstrong wrote:
> On 27/05/2024 10:46, Dmitry Baryshkov wrote:
> > On Mon, May 27, 2024 at 10:42:35AM +0200, Neil Armstrong wrote:
> > > Introduce an enum for the QMP Combo PHY modes, use it in the
> > > QMP commmon phy init function and default to COMBO mode.
> > >
> > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > > ---
> > > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 41 +++++++++++++++++++++++++++----
> > > 1 file changed, 36 insertions(+), 5 deletions(-)
> > >
[trimmed]
> > > @@ -3603,6 +3631,9 @@ static int qmp_combo_probe(struct platform_device *pdev)
> > > if (ret)
> > > goto err_node_put;
> > > + /* Set PHY_MODE as combo by default */
> > > + qmp->init_mode = QPHY_MODE_COMBO;
> > > +
> >
> > I see that COMBO mode is backwards compatible with existing code. But
> > shouldn't the USB-only be a default mode?
>
> No because it would break existing platforms without "mode-switch" in DT.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>
> Neil
>
> >
> > > qmp->usb_phy = devm_phy_create(dev, usb_np, &qmp_combo_usb_phy_ops);
> > > if (IS_ERR(qmp->usb_phy)) {
> > > ret = PTR_ERR(qmp->usb_phy);
> > >
> > > --
> > > 2.34.1
> > >
> >
>
--
With best wishes
Dmitry
