On 27/05/2024 10:25, Kamlesh Gurudasani wrote: > Conor Dooley <conor@xxxxxxxxxx> writes: > >> On Fri, Aug 11, 2023 at 04:34:33PM +0100, Conor Dooley wrote: >>> On Fri, Aug 11, 2023 at 12:58:50AM +0530, Kamlesh Gurudasani wrote: >>>> Add binding for Texas Instruments MCRC64 >>>> >>>> MCRC64 engine calculates 64-bit cyclic redundancy checks (CRC) >>>> according to the ISO 3309 standard. >>>> >>>> The ISO 3309 64-bit CRC model parameters are as follows: >>>> Generator Polynomial: x^64 + x^4 + x^3 + x + 1 >>>> Polynomial Value: 0x000000000000001B >>>> Initial value: 0x0000000000000000 >>>> Reflected Input: False >>>> Reflected Output: False >>>> Xor Final: 0x0000000000000000 >>>> >>>> Signed-off-by: Kamlesh Gurudasani <kamlesh@xxxxxx> >>>> --- >>>> Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml | 47 +++++++++++++++++++++++++++++++++++++++++++++++ >>>> MAINTAINERS | 5 +++++ >>>> 2 files changed, 52 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml b/Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml >>>> new file mode 100644 >>>> index 000000000000..38bc7efebd68 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml >>>> @@ -0,0 +1,47 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> +$id: http://devicetree.org/schemas/crypto/ti,mcrc64.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Texas Instruments MCRC64 >>>> + >>>> +description: The MCRC64 engine calculates 64-bit cyclic redundancy checks >>> >>> A newline after "description" please. >>> >>>> + (CRC) according to the ISO 3309 standard. >>>> + >>>> +maintainers: >>>> + - Kamlesh Gurudasani <kamlesh@xxxxxx> >>>> + >>>> +properties: >>>> + compatible: >>>> + const: ti,am62-mcrc64 >>> >>> Is the am62 an SoC or a family of SoCs? I googled a wee bit for am62 & >>> there seems to be an am625 and an am623? >> >> Or is it an am62p5, in which case the compatible should contain >> ti,am62p5 I suppose. Sorry for my confusion here, its not really clear >> me too since I've been seeing many different-but-similar product names >> the last few days. >> >> Thanks, >> Conor. >> > Hi Conor, > > Thanks for the review. > > am62 is family of SOCs. > > All devices under this family, like am623/5/p5 and etc, have MCRC64. > > I have kept the naming convention similar to SA2UL/SA3UL[0]. > > [0] https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml#L18 Usual answer is: no families. There are exceptions, though, so is this case on the exception list? https://elixir.bootlin.com/linux/v6.10-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 P.S. Your email client added some weird subject prefix - please fix it. Best regards, Krzysztof