Hi, Alexandre: On Thu, 2024-05-23 at 14:49 +0200, amergnat@xxxxxxxxxxxx wrote: > > External email : Please do not click links or open attachments until you have verified the sender or the content. > From: Fabien Parent <fparent@xxxxxxxxxxxx> > > DPI is part of the display / multimedia block in MediaTek SoCs, and > always have a power-domain (at least in the upstream device-trees). > Add the power-domains property to the binding documentation. Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx> > > Fixes: 9273cf7d3942 ("dt-bindings: display: mediatek: convert the dpi bindings to yaml") > Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > Signed-off-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > index 6607cb1c6e0a..169d054d81ff 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > @@ -80,6 +80,9 @@ properties: > - port@0 > - port@1 > > + power-domains: > + maxItems: 1 > + > required: > - compatible > - reg > @@ -99,11 +102,13 @@ examples: > - | > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/clock/mt8173-clk.h> > + #include <dt-bindings/power/mt8173-power.h> > > dpi: dpi@1401d000 { > compatible = "mediatek,mt8173-dpi"; > reg = <0x1401d000 0x1000>; > interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_LOW>; > + power-domains = <&spm MT8173_POWER_DOMAIN_MM>; > clocks = <&mmsys CLK_MM_DPI_PIXEL>, > <&mmsys CLK_MM_DPI_ENGINE>, > <&apmixedsys CLK_APMIXED_TVDPLL>; > > -- > 2.25.1 >