Hi Volodymyr, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Volodymyr-Kharuk/media-uapi-ctrls-Add-camera-trigger-controls/20240517-004536 base: 8771b7f31b7fff91a998e6afdb60650d4bac59a5 patch link: https://lore.kernel.org/r/6f666d475da17b3469fd0471531bc615f6fd797a.1715871189.git.vkh%40melexis.com patch subject: [PATCH v6 10/10] media: i2c: Add driver for mlx7502x ToF sensor config: mips-randconfig-r071-20240518 (https://download.01.org/0day-ci/archive/20240518/202405181557.HpbDJU4b-lkp@xxxxxxxxx/config) compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project fa9b1be45088dce1e4b602d451f118128b94237b) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202405181557.HpbDJU4b-lkp@xxxxxxxxx/ smatch warnings: drivers/media/i2c/mlx7502x.c:664 mlx7502x_runtime_resume() warn: 'sensor->xclk' from clk_prepare_enable() not released on lines: 664. drivers/media/i2c/mlx7502x.c:1586 mlx7502x_link_freq_init() error: buffer overflow 'link_freq' 6 <= 6 (assuming for loop doesn't break) vim +664 drivers/media/i2c/mlx7502x.c 93b22d3a235baf Volodymyr Kharuk 2024-05-16 620 static int __maybe_unused mlx7502x_runtime_resume(struct device *dev) 93b22d3a235baf Volodymyr Kharuk 2024-05-16 621 { 93b22d3a235baf Volodymyr Kharuk 2024-05-16 622 struct v4l2_subdev *sd = dev_get_drvdata(dev); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 623 struct mlx7502x *sensor = to_mlx7502x(sd); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 624 int ret; 93b22d3a235baf Volodymyr Kharuk 2024-05-16 625 93b22d3a235baf Volodymyr Kharuk 2024-05-16 626 gpiod_set_value_cansleep(sensor->reset, 0); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 627 93b22d3a235baf Volodymyr Kharuk 2024-05-16 628 ret = regulator_bulk_enable(MLX7502X_NUM_SUPPLIES, sensor->supplies); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 629 if (ret) { 93b22d3a235baf Volodymyr Kharuk 2024-05-16 630 dev_err(sensor->dev, "failed to enable supply: %d\n", ret); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 631 return ret; 93b22d3a235baf Volodymyr Kharuk 2024-05-16 632 } 93b22d3a235baf Volodymyr Kharuk 2024-05-16 633 93b22d3a235baf Volodymyr Kharuk 2024-05-16 634 ret = clk_prepare_enable(sensor->xclk); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 93b22d3a235baf Volodymyr Kharuk 2024-05-16 635 if (ret) { 93b22d3a235baf Volodymyr Kharuk 2024-05-16 636 dev_err(sensor->dev, "failed to enable external clock: %d\n", 93b22d3a235baf Volodymyr Kharuk 2024-05-16 637 ret); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 638 goto fail_clk; 93b22d3a235baf Volodymyr Kharuk 2024-05-16 639 } 93b22d3a235baf Volodymyr Kharuk 2024-05-16 640 93b22d3a235baf Volodymyr Kharuk 2024-05-16 641 gpiod_set_value_cansleep(sensor->reset, 1); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 642 msleep(MLX7502X_RESET_DELAY_MS); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 643 93b22d3a235baf Volodymyr Kharuk 2024-05-16 644 dev_dbg(sensor->dev, "power on\n"); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 645 93b22d3a235baf Volodymyr Kharuk 2024-05-16 646 ret = mlx7502x_write_regval(sd, mlx7502x_common_init_cfg, 93b22d3a235baf Volodymyr Kharuk 2024-05-16 647 ARRAY_SIZE(mlx7502x_common_init_cfg)); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 648 if (ret < 0) { 93b22d3a235baf Volodymyr Kharuk 2024-05-16 649 dev_err(sensor->dev, "failed to write init_cfg\n"); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 650 goto fail_clk; Don't we need to disable the xclk on this path? 93b22d3a235baf Volodymyr Kharuk 2024-05-16 651 } 93b22d3a235baf Volodymyr Kharuk 2024-05-16 652 93b22d3a235baf Volodymyr Kharuk 2024-05-16 653 ret = mlx7502x_write_regval(sd, sensor->cur_desc->init_cfg, 93b22d3a235baf Volodymyr Kharuk 2024-05-16 654 sensor->cur_desc->init_cfg_size); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 655 if (ret < 0) { 93b22d3a235baf Volodymyr Kharuk 2024-05-16 656 dev_err(sensor->dev, "failed to write sensor specific init_cfg\n"); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 657 goto fail_clk; And here. 93b22d3a235baf Volodymyr Kharuk 2024-05-16 658 } 93b22d3a235baf Volodymyr Kharuk 2024-05-16 659 93b22d3a235baf Volodymyr Kharuk 2024-05-16 660 return 0; 93b22d3a235baf Volodymyr Kharuk 2024-05-16 661 93b22d3a235baf Volodymyr Kharuk 2024-05-16 662 fail_clk: 93b22d3a235baf Volodymyr Kharuk 2024-05-16 663 regulator_bulk_disable(MLX7502X_NUM_SUPPLIES, sensor->supplies); 93b22d3a235baf Volodymyr Kharuk 2024-05-16 @664 return ret; 93b22d3a235baf Volodymyr Kharuk 2024-05-16 665 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
