On 5/22/24 16:46, Rob Herring (Arm) wrote: > > On Wed, 22 May 2024 01:21:52 +0300, Jan Dakinevich wrote: >> - Make some cosmetics in existing device tree files; >> >> - Add the board. >> >> Jan Dakinevich (3): >> arch/arm64: dts: ac2xx: make common the sound card >> dt-bindings: arm: amlogic: document AC200 support >> arch/arm64: dts: ac200: introduce initial support of the board >> >> .../devicetree/bindings/arm/amlogic.yaml | 1 + >> .../dts/amlogic/meson-sm1-a95xf3-air-gbit.dts | 87 ------------------- >> .../boot/dts/amlogic/meson-sm1-a95xf3-air.dts | 87 ------------------- >> .../boot/dts/amlogic/meson-sm1-ac200.dts | 22 +++++ >> .../boot/dts/amlogic/meson-sm1-ac2xx.dtsi | 87 +++++++++++++++++++ >> .../boot/dts/amlogic/meson-sm1-h96-max.dts | 87 ------------------- >> .../dts/amlogic/meson-sm1-x96-air-gbit.dts | 87 ------------------- >> .../boot/dts/amlogic/meson-sm1-x96-air.dts | 87 ------------------- >> 8 files changed, 110 insertions(+), 435 deletions(-) >> create mode 100644 arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dts >> >> -- >> 2.34.1 >> >> >> > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y amlogic/meson-sm1-a95xf3-air-gbit.dtb amlogic/meson-sm1-a95xf3-air.dtb amlogic/meson-sm1-ac200.dtb amlogic/meson-sm1-h96-max.dtb amlogic/meson-sm1-x96-air-gbit.dtb amlogic/meson-sm1-x96-air.dtb' for 20240521222155.28094-1-jan.dakinevich@xxxxxxxxxxxxxxxxx: > > arch/arm64/boot/dts/amlogic/meson-sm1-x96-air-gbit.dtb: audio-controller@380: compatible: ['amlogic,sm1-tdmin', 'amlogic,axg-tdmin'] is too long > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-formatters.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: /soc/bus@ff600000/bus@60000/clock-controller@0: failed to match any schema with compatible: ['amlogic,sm1-audio-clkc'] > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller@300: compatible: ['amlogic,sm1-tdmin', 'amlogic,axg-tdmin'] is too long > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-formatters.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller@340: compatible: ['amlogic,sm1-tdmin', 'amlogic,axg-tdmin'] is too long > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-formatters.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller@380: compatible: ['amlogic,sm1-tdmin', 'amlogic,axg-tdmin'] is too long > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-formatters.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller@3c0: compatible: ['amlogic,sm1-tdmin', 'amlogic,axg-tdmin'] is too long > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-formatters.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: /soc/bus@ff600000/bus@60000/audio-controller@744: failed to match any schema with compatible: ['amlogic,sm1-tohdmitx', 'amlogic,g12a-tohdmitx'] > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: /soc/bus@ff600000/bus@60000/audio-controller@744: failed to match any schema with compatible: ['amlogic,sm1-tohdmitx', 'amlogic,g12a-tohdmitx'] > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: sys-ctrl@0: '#address-cells', '#size-cells', 'ranges' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller-0: clock-names:0: 'sclk' was expected > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-iface.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller-0: clock-names:1: 'lrclk' was expected > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-iface.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller-0: clock-names:2: 'mclk' was expected > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-iface.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller-1: clock-names:0: 'sclk' was expected > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-iface.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller-1: clock-names:1: 'lrclk' was expected > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-iface.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller-1: clock-names:2: 'mclk' was expected > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-iface.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller-1: Unevaluated properties are not allowed ('clock-names' was unexpected) > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-iface.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller-2: clock-names:0: 'sclk' was expected > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-iface.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller-2: clock-names:1: 'lrclk' was expected > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-iface.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: audio-controller-2: clock-names:2: 'mclk' was expected > from schema $id: http://devicetree.org/schemas/sound/amlogic,axg-tdm-iface.yaml# > arch/arm64/boot/dts/amlogic/meson-sm1-ac200.dtb: sound: 'anyOf' conditional failed, one must be fixed: > 'clocks' is a required property > '#clock-cells' is a required property > from schema $id: http://devicetree.org/schemas/clock/clock.yaml# > > > > > These errors were here before my modifications, and they require extra efforts to rework generic 'meson-sm1.dtsi' etc. But it is not the goal of this series. Should I do anything about this right now? -- Best regards Jan Dakinevich
