On 22/05/2024 15:56, Péter Ujfalusi wrote:
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> + - ti,hwmods
>> + - clocks
>> + - clock-names
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + pdm@40132000 {
>
> The original label and name is preferred to be used.
Label is not used here.
About node name, not:
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
>> + compatible = "ti,omap4-mcpdm";
>> + reg = <0x40132000 0x7f>, /* MPU private access */
>> + <0x49032000 0x7f>; /* L3 Interconnect */
>> + interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-parent = <&gic>;
>> + ti,hwmods = "mcpdm";
>> + clocks = <&twl6040>;
>> + clock-names = "pdmclk";
>
> The clocks cannot be added at the time when the node is defined, it is
> board specific. This way you imply that it is OK to have it in main dtsi
> file. It is not.
Wait, what? That's example and pretty standard. Example should be
complete. This is not an exceptional binding.
Best regards,
Krzysztof
