On 11/05/2024 23:47, Xiaxi Shen wrote:
> Convert adi,ssm2305 binding to DT schema
>
> It passed dt_binding_check and dtbs_check. Let me know
> if you think it should include something else
That's not really related to the commit.
>
> Signed-off-by: Xiaxi Shen <shenxiaxi26@xxxxxxxxx>
> ---
> .../devicetree/bindings/sound/adi,ssm2305.txt | 14 --------
> .../bindings/sound/adi,ssm2305.yaml | 35 +++++++++++++++++++
Same comment as usual... there are no DTS users. Are we done with arm64
defconfig and arm multi_v7 undocumented compatibles? I doubt, 2 months
ago there were hundreds of them. Why touching something without users?
I was speaking about this *multiple times*. Can you update your GSoC or
mentorship guidelines to include this information?
> 2 files changed, 35 insertions(+), 14 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.txt
> create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
>
...
> +maintainers:
> + - Liam Girdwood <lgirdwood@xxxxxxxxx>
> + - Mark Brown <broonie@xxxxxxxxxx>
> + - Rob Herring <robh@xxxxxxxxxx>
> + - Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> + - Conor Dooley <conor+dt@xxxxxxxxxx>
Not really, this should be someone responsible for the device. No
maintainers or recent, main contributors?
> +
> +properties:
> + compatible:
> + const: adi,ssm2305
> +
> + shutdown-gpios:
> + maxItems: 1
> + description: The gpio connected to the shutdown pin. The gpio signal is ACTIVE_LOW.
> +
> +required:
> + - compatible
> + - shutdown-gpios> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + analog-amplifier {
> + compatible = "adi,ssm2305";
> + shutdown-gpios = <&gpio3 20 0>;
Use proper define for the flag.
> + };
Best regards,
Krzysztof
