On 20/05/2024 22:39, Frank Li wrote: > Convert binding doc from txt to yaml. > > Re-order interrupt-names to align example. > +properties: > + compatible: > + enum: > + - fsl,ls1021a-qdma > + - fsl,ls1028a-qdma > + - fsl,ls1043a-qdma > + - fsl,ls1046a-qdma > + > + reg: > + items: > + - description: Controller regs > + - description: Status regs > + - description: Block regs > + > + interrupts: > + minItems: 2 > + maxItems: 5 > + > + interrupt-names: > + minItems: 2 > + items: > + - const: qdma-error > + - const: qdma-queue0 > + - const: qdma-queue1 > + - const: qdma-queue2 > + - const: qdma-queue3 > + > + dma-channels: > + minItems: 1 > + maxItems: 64 That's not a list. Did you just copy buggy fsl-edma? > + > + fsl,dma-queues: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Should contain number of queues supported. Constraints? > + > + block-number: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: the virtual block number > + > + block-offset: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: the offset of different virtual block > + > + status-sizes: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: status queue size of per virtual block > + > + queue-sizes: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: > + command queue size of per virtual block, the size number > + based on queues > + > + big-endian: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + If present registers and hardware scatter/gather descriptors > + of the qDMA are implemented in big endian mode, otherwise in little > + mode. > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-names > + - fsl,dma-queues > + - block-number > + - block-offset > + - status-sizes > + - queue-sizes > + > +unevaluatedProperties: false > + > +allOf: > + - $ref: dma-controller.yaml# This goes above unevaluatedProperties. Please constrain interrupts per variant. Best regards, Krzysztof
