On 20/05/2024 23:20, Rob Herring wrote: > On Sun, May 19, 2024 at 08:42:21PM +0200, Krzysztof Kozlowski wrote: >> Simple syscon nodes can be documented in common syscon.yaml, however >> devices with simple-mfd compatible, thus with some children, should have >> their own schema listing these children. Such listing makes the binding >> specific, allows better validation (so the incorrect child would not >> appear in the simple-mfd node) and actually enforces repeated rule for >> simple-mfd devices: >> >> "simple-mfd" is only for simple devices, where the children do not >> depend on the parent. >> >> Currently the syscon+simple-mfd binding is quite broad and allows >> any child or property, thus above rule cannot be enforced. >> >> Split the syscon.yaml binding into: >> 1. Common syscon properties, used potentially by many bindings. >> 2. Simple syscon devices (NO simple-mfd!). >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> ... >> >> description: | >> System controller node represents a register region containing a set >> @@ -19,122 +19,99 @@ description: | >> maintainers: >> - Lee Jones <lee@xxxxxxxxxx> >> >> -select: >> - properties: >> - compatible: >> - contains: >> - enum: >> - - syscon >> - >> - required: >> - - compatible >> - > > Removing this is only going to work with v2024.04. The only way it > works for older versions is listing all the compatibles here. That's a > bit new for us to require it. I'll keep it, in such case. Anyway its removal is not really related to main concept of this patch. Best regards, Krzysztof
