On 19/05/2024 13:40, Krzysztof Kozlowski wrote: > On 17/05/2024 14:58, Alvin Šipraga wrote: >> From: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx> >> >> Add device tree bindings for the AD24xx series A2B transceiver chips, >> including their functional blocks. >> >> Signed-off-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/a2b/adi,ad24xx-clk.yaml | 53 +++++ > > What is a2b and why clock bindings are not in clock? Just in case you reply "but I have cover letter", so no, it does not matter really. This is the patch describing hardware, so here you describe hardware. Not in cover letter which often is ignored. Many people, including myself, skip cover letters. Provide *hardware* description here. Best regards, Krzysztof