Re: [PATCH 01/13] a2b: add A2B driver core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



…
> +++ b/drivers/a2b/a2b.c
> @@ -0,0 +1,1252 @@
…
> +static int a2b_node_uevent(const struct device *dev,
> +			   struct kobj_uevent_env *env)
> +{
…
> +		if (add_uevent_var(env, "A2B_NODE_VENDOR=%02x", node->vendor))
> +			return -ENOMEM;
…
> +		if (add_uevent_var(env, "A2B_NODE_VERSION=%02x", node->version))
> +			return -ENOMEM;
…


I suggest to merge three if statements into one in a branch of
this function implementation.

Regards,
Markus





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux