Re: [PATCH] arm64: dts: qcom: qdu/qru1000-idp: Fix the voltage setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16/05/2024 07:52, Komal Bajaj wrote:
> 
> 
> On 5/14/2024 6:57 PM, Krzysztof Kozlowski wrote:
>> On 14/05/2024 15:10, Komal Bajaj wrote:
>>> Fixing the regulator voltages for qdu/qru1000 idp boards.
>>> In particular -
>>> - smps4 is 1.574V min and 2.04V max
>>> - smps5 is 1.2V min and 1.4V max
>>> - smps6 is 0.382V min and 1.12V max
>>
>> Wait, why? This looks, at least partially, you are changing from fixed
>> voltage choice to full range, without clear explanation.
>>
> 
> When we started using one of these regulators for USB enablement as sent 
> in the patch series [1], we saw a sudden reboot.
> After adding more debug logs, came to know the configuration for smps5 
> was incorrect.
> 
> Therefore, cross verified the configurations for all the regulators and 
> got to know that these are incorrectly configured.
> This fixes some manual errors introduced in the initial patch (mentioned 
> in fixes tag).
> 
> [1] 
> https://lore.kernel.org/linux-arm-msm/20240502090326.21489-1-quic_kbajaj@xxxxxxxxxxx/

All this should be explained in commit msg.

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux