> > I suspect it might make sense to add this WoL part separately from the > > actual ethernet DT nodes, so ethernet could land and the WoL > > functionality can be added when it is ready ? > > If at the end we want to have this Wol from PHY then I agree we need to > wait. We could push a WoL from MAC for this node before optee driver patches > merge but not sure it makes sens. In general, it is better if the PHY does WoL, since the MAC can then be powered down. MAC WoL should only be used when the PHY does not support the requested WoL configuration, but the MAC can. And sometimes you need to spread it over both the PHY and the MAC. Andrew