On 15/05/2024 16:07, Pratik Farkase wrote: > Signed-off-by: Pratik Farkase <pratik.farkase@xxxxxxxxxxxxx> That's not a proper commit... Read introduction to Git how to create commits. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters Code itself looked good. Best regards, Krzysztof