On 15/05/2024 14:09, Naina Mehta wrote: > Enable SDHCI on sdx75-idp to support SD card. > Also add the required regulators. > > Signed-off-by: Naina Mehta <quic_nainmeht@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sdx75-idp.dts | 45 ++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdx75-idp.dts b/arch/arm64/boot/dts/qcom/sdx75-idp.dts > index f76e72fb2072..6f94278cf837 100644 > --- a/arch/arm64/boot/dts/qcom/sdx75-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sdx75-idp.dts > @@ -41,6 +41,29 @@ > > vin-supply = <&vph_ext>; > }; > + > + vreg_sd_vccb: sd-vccb { Please use name for all fixed regulators which matches current format recommendation: 'regulator-[0-9]+v[0-9]+' https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?id=b6d4b3500d57370f5b3abf0701c9166b384db976 Best regards, Krzysztof