On Fri, 2024-05-10 at 07:48 -0500, Rob Herring wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Fri, May 10, 2024 at 07:04:15PM +0800, Liankun Yang wrote: > > Add dp PHY dt-bindings. > > > > Changeds in v2: > > - Add dp PHY dt-bindings. > > https://patchwork.kernel.org/project/linux-mediatek/patch/ > > 20240403040517.3279-1-liankun.yang@xxxxxxxxxxxx/ > > > > Signed-off-by: Liankun Yang <liankun.yang@xxxxxxxxxxxx> > > --- > > .../display/mediatek/mediatek.phy-dp.yaml | 45 > +++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > create mode 100644 > Documentation/devicetree/bindings/display/mediatek/mediatek.phy- > dp.yaml > > > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek.phy- > dp.yaml > b/Documentation/devicetree/bindings/display/mediatek/mediatek.phy- > dp.yaml > > git refuses to apply your patch because 'new file mode 100644' is > missing. You must have edited the patch or something. > > If it did apply, you'd notice it fails testing. > After checking patch,one warning is new file is 'new file mode 100644'. I will pay attention to the problem in a later patch. > > index 000000000000..476bc329363f > > --- /dev/null > > +++ > b/Documentation/devicetree/bindings/display/mediatek/mediatek.phy- > dp.yaml > > @@ -0,0 +1,45 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > http://devicetree.org/schemas/display/mediatek/mediatek,phy-dp.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek Display Port Controller > > + > > +maintainers: > > + - Mac shen <mac.shen@xxxxxxxxxxxx> > > + - Liankun yang <Liankun.yang@xxxxxxxxxxxx> > > + > > +description: | > > + Special settings need to be configured by MediaTek DP based on > the actual > > + hardware situation. For example, when using a certain brand's > docking > > + station for display projection, garbage may appear. Adjusting > the specific > > + ssc value can resolve this issue. > > + > > +properties: > > + status: disabled > > + description: | > > + Since the DP driver has already registered the DP PHY device > > + through mtk_dp_register_phy(), so the status is disabled. > > What!? Please show me any other binding that has 'status' in it. Go > read > up on how to write bindings and what goes in them. > Sorry,thank you for your comments. I immediately learn how to write bindings. > > + > > + dp-ssc-setting: > > + - ssc-delta-hbr > > + description: Specific values are set based on the actual HW > situation. > > + > > +required: > > + - status > > + - dp-ssc-setting > > + > > +examples: > > + - | > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + phy-dp@1c600000 { > > + status = "disabled"; > > + dp-ssc-setting { > > + ssc-delta-hbr = <0x01fe>; > > + } > > + }; > > + }; > > -- > > 2.18.0 > > Best regards, Liankun yang
