On Sun, May 12, 2024 at 10:06:23PM +0300, Jan Dakinevich wrote:
>
>
> On 5/8/24 20:50, Rob Herring wrote:
> > On Wed, May 08, 2024 at 05:42:58PM +0300, Jan Dakinevich wrote:
> >> Signed-off-by: Jan Dakinevich <jan.dakinevich@xxxxxxxxxxxxxxxxx>
> >> ---
> >> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 27 ++++++++++++++++++++--
> >> arch/arm64/boot/dts/amlogic/meson-g12.dtsi | 26 +++++++++++++++++++--
> >> arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 26 +++++++++++++++++++--
> >> 3 files changed, 73 insertions(+), 6 deletions(-)
> >>
> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> >> index 6d12b760b90f..28f4ec5f39b0 100644
> >> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> >> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> >> @@ -1342,7 +1342,9 @@ clkc_audio: clock-controller@0 {
> >> <&clkc CLKID_HIFI_PLL>,
> >> <&clkc CLKID_FCLK_DIV3>,
> >> <&clkc CLKID_FCLK_DIV4>,
> >> - <&clkc CLKID_GP0_PLL>;
> >> + <&clkc CLKID_GP0_PLL>,
> >> + <0>, <0>, <0>, <0>, <0>, <0>, <0>, <0>, <0>, <0>,
> >> + <0>, <0>, <0>, <0>, <0>, <0>, <0>, <0>, <0>, <0>;
> >
> > All 3 cases are just unused clocks on the end. I suppose that's not
> > always the case. You could just set 'minItems' in the binding to
> > avoid needing to pad the end and the dts changes.
> >
>
> You are right. I mistakenly thought that 'minItems' can not be
> redefined. But not, it is allowed to redefine it and it works. Thus,
> this patch is not needed for this approach.
>
> Anyway, what do you think about first approach? As for me, it is more
> simple and readable.
I prefer this one as it enforces the order.
Rob
