On 13/05/2024 10:47, Tengfei Fan wrote: > All the board dts which base on SM8550 SoC dtsi refer to usb_1_dwc3_ss, > usb_dp_qmpphy_usb_ss_in, orientation-switch and usb-role-switch, so move > them to SoC dtsi from board dts. That's not really a good argument. Argument is that it is a SoC property (vs being a property of a board). Provide rationale for that. You are moving things just because they look common, so to me it looks really unjustified. > OTG is default for dr_mode, so it can be dropped from board dts. Separate patch, see submitting patches. Best regards, Krzysztof
