On Fri, May 10, 2024 at 12:54:17PM +0200, Luca Ceresoli wrote: > > > +static int sunh_conn_handle_event(struct sunh_conn *conn, bool plugged) > > > +{ > > > + int err; > > > + > > > + if (plugged == conn->plugged) > > > + return 0; > > > + > > > + dev_info(conn->dev, "%s\n", plugged ? "connected" : "disconnected"); > > > > Please remove debugging code from stuff you want to see merged. > > > > Same for all dev_info() calls here, when drivers work properly, they are > > quiet. > > While agree for other dev_info() calls, this one seems quite similar in > principle to the link up/down messages that get logged by the MII code > at [0]: > > [347229.872315] asix 1-1.3.2:1.0 enx000cf616fecb: link up, 100Mbps, > full-duplex, lpa 0xC5E1 [347229.920449] asix 1-1.3.2:1.0 enx000cf616fecb: link down > > In my case it is logging that a removable part of the hardware has been > added or removed, which appears useful. Do you think it make sense in > this scenario? Nope, sorry, again, when drivers are working properly, they should be quiet otherwise they just fill up the log with unneeded messages. thanks, greg k-h