On Tue, May 07, 2024 at 08:22:34PM +0300, Andy Shevchenko wrote: > On Tue, May 7, 2024 at 6:44 PM Johan Hovold <johan@xxxxxxxxxx> wrote: > > On Mon, May 06, 2024 at 10:09:50PM +0300, Andy Shevchenko wrote: > > > Mon, May 06, 2024 at 05:08:29PM +0200, Johan Hovold kirjoitti: > > > > [ johan: rework probe to match new binding, amend commit message and > > > > Kconfig entry] > > > > > > Wouldn't be better on one line? > > > > Now you're really nit picking. ;) I think I prefer to stay within 72 > > columns. > > Not really. The tag block is special and the format is rather one > entry per line. This might break some scriptings. This is not a tag, and using line breaks here is perfectly fine. > > > return dev_err_probe(...); > > > > Nah, regmap won't trigger a probe deferral. > > And it doesn't matter. What we gain with dev_err_probe() is: > - special handling of deferred probe > - unified format of messages in ->probe() stage > > The second one is encouraged. I don't care about your personal preferences. Johan
