Hello. On 02/22/2015 03:45 AM, Magnus Damm wrote:
Define the SILK board dependent parts of the SDHI0 (connected to SDIO Wi-Fi chip) and SDHI1 (connected to micro-SD slot) device nodes along with the necessary voltage regulators.
Based on the original patch by Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
Thanks for your patch. One question - above you write that SDHI1 is micro-SD...
Yes, have double-checked now.
@@ -100,3 +159,25 @@ non-removable; status = "okay"; }; + +&sdhi0 { + pinctrl-0 = <&sdhi0_pins>; + pinctrl-names = "default"; + + vmmc-supply = <&vcc_sdhi0>; + vqmmc-supply = <&vccq_sdhi0>; + cd-gpios = <&gpio6 6 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio6 7 GPIO_ACTIVE_LOW>; + status = "okay"; +}; + +&sdhi1 { + pinctrl-0 = <&sdhi1_pins>; + pinctrl-names = "default"; + + vmmc-supply = <&vcc_sdhi1>; + vqmmc-supply = <&vccq_sdhi1>; + cd-gpios = <&gpio6 14 GPIO_ACTIVE_LOW>; + wp-gpios = <&gpio6 15 GPIO_ACTIVE_LOW>; + status = "okay"; +};
... however here the WP signal is assigned.
I believe micro-SD doesn't use the WP signal, so either I'm wrong or the patch needs to be updated to reflect reality. =)
Both seem correct: SD1_WP signal is just tied to VCCQ_SD1. Do you think we should still drop it?
Also, I doubt that an on-board SDIO module makes use of CD and/or WP signals?
Those two are tied to VCCQ_SD0 as well. Do you think we should drop them?
Thanks, / magnus
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
