On Wed, May 08, 2024 at 09:41:24AM +0000, Peng Fan wrote: > Hi Sudeep, > > > Subject: Re: [PATCH v5 0/3] pinctrl: scmi: support i.MX95 OEM extensions > > > > On Wed, May 08, 2024 at 11:32:01AM +0800, Peng Fan (OSS) wrote: > > > ARM SCMI v3.2 Table 24 Pin Configuration Type and Enumerations: > > > '192 -255 OEM specific units'. > > > > > > i.MX95 System Manager FW supports SCMI PINCTRL protocol, but it has > > > zero functions, groups. So pinctrl-scmi.c could not be reused for i.MX95. > > > Because nxp,pin-func, nxp,pin-conf properties are rejected by dt > > > maintainers, so use generic property 'pinmux' which requires a new > > > driver pinctrl-imx-scmi.c > > > > > > > Not a review in particular, but if we decide to merge this deviation, it must be > > under the condition that it can be deleted anytime in the future if this > > becomes annoyance(like other vendors using this as a way to deviate from > > the specification). If we can't agree with that, then we better not merge this > > at all. > > It is ok for me. I agree. > But actually this driver still follows Spec by using OEM extensions. > Agreed, but that's what I call as deviations. When such extensions are used as baseline implementation, it becomes deviations. -- Regards, Sudeep
