Re: [PATCH v2 01/11] dt-bindings: clock: mobileye,eyeq5-clk: drop bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/05/2024 17:07, Théo Lebrun wrote:
> Hello,
> 
> On Fri May 3, 2024 at 6:05 PM CEST, Krzysztof Kozlowski wrote:
>> On 03/05/2024 17:57, Krzysztof Kozlowski wrote:
>>> On 03/05/2024 16:20, Théo Lebrun wrote:
>>>> Switch from sub-nodes in system-controller for each functionality to a
>>>> single node representing the entire OLB instance. dt-bindings is
>>>> unnecessary and soc/mobileye/mobileye,eyeq5-olb.yaml will inherit all
>>>> properties.
>>>
>>> Why changing this? You just added these bindings not so long time ago...
>>> This is very confusing to push bindings and then immediately ask to
>>> remove them.
> 
> See this revision as a proposal of something that has been asked
> multiple times in previous reviews. See message from Stephen Boyd on

That's driver, we talk about bindings.

> last revision [0], or discussion with Rob Herring on much earlier
> revision [1].
> 
> Proposal from Stephen Boyd of using auxiliary devices makes sense, that
> could be the future direction of this series. It won't change the
> dt-bindings aspect of it, only the driver implementations.
> 
> [0]: https://lore.kernel.org/lkml/daa732cb31d947c308513b535930c729.sboyd@xxxxxxxxxx/
> [1]: https://lore.kernel.org/lkml/20240124151405.GA930997-robh@xxxxxxxxxx/

So after Robs comment above, you still pushed the wrong approach and now
you revert it?

Why v7 was sent ignoring Rob's comments:
https://lore.kernel.org/all/20240221-mbly-clk-v7-3-31d4ce3630c3@xxxxxxxxxxx/

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux