On 06/05/2024 16:43, Vikash Garodia wrote:
> On 5/6/2024 7:17 PM, Marc Gonzalez wrote:
>
>> From: Pierre-Hugues Husson <phhusson@xxxxxxxxxx>
>>
>> Add the missing bits for msm8998 support.
>>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
>> Signed-off-by: Pierre-Hugues Husson <phhusson@xxxxxxxxxx>
>> Signed-off-by: Marc Gonzalez <mgonzalez@xxxxxxxxxx>
>> ---
>> drivers/media/platform/qcom/venus/core.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 48 insertions(+)
>>
>> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
>> index ce206b7097541..064120127cb86 100644
>> --- a/drivers/media/platform/qcom/venus/core.c
>> +++ b/drivers/media/platform/qcom/venus/core.c
>> @@ -554,6 +554,9 @@ static const struct venus_resources msm8916_res = {
>> .fwname = "qcom/venus-1.8/venus.mbn",
>> };
>>
>> +/*
>> + * https://git.codelinaro.org/clo/la/kernel/msm-4.4/-/blame/caf_migration/kernel.lnx.4.4.r38-rel/arch/arm/boot/dts/qcom/msm8996-v3.dtsi#L403-414
>> + */
>
> There is no need to add the link to downstream code in comments. Please remove them.
They are needed somewhere, to double check the values.
Otherwise, it's just voodoo programming.
If not in the code, then maybe in the commit message?
Since qcom doesn't publish datasheets, downstream code
is the best we've got.
Regards
