On 05/05/2024 15:41, Jonas Karlman wrote:
> Similar to RK817 the RK809 also integrates a complete audio system.
>
> Add audio codec properties to binding to reflect this.
>
> Signed-off-by: Jonas Karlman <jonas@xxxxxxxxx>
Except sending untested patches...
> ---
> .../bindings/mfd/rockchip,rk809.yaml | 34 ++++++++++++++++++-
> 1 file changed, 33 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> index c951056b8b4d..b78e1b090105 100644
> --- a/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk809.yaml
> @@ -12,7 +12,7 @@ maintainers:
>
> description: |
> Rockchip RK809 series PMIC. This device consists of an i2c controlled MFD
> - that includes regulators, an RTC, and power button.
> + that includes regulators, an RTC, a power button and an audio codec.
>
> properties:
> compatible:
> @@ -93,6 +93,34 @@ properties:
> unevaluatedProperties: false
> unevaluatedProperties: false
>
> + clocks:
> + description:
> + The input clock for the audio codec.
No, this allows anything. You must be here specific, see example-schema.
maxItems: 1
Drop description, redundant.
> +
> + clock-names:
> + description:
> + The clock name for the codec clock.
Drop description, redundant.
> + items:
> + - const: mclk
> +
> + '#sound-dai-cells':
> + description:
> + Needed for the interpretation of sound dais.
Drop description, redundant. Do you see it anywhere for such properties?
> + const: 0
Missing ref to dai-common in your allOf (again: take a look how other
bindings are doing it).
> +
> + codec:
> + description: |
Do not need '|' unless you need to preserve formatting.
> + The child node for the codec to hold additional properties. If no
> + additional properties are required for the codec, this node can be
> + omitted.
That's useless description. Describe hardware, not syntax. This must say
what this node represents.
Anyway drop it. You do not have any resources there, so put properties
in top level.
> + type: object
> + additionalProperties: false
> + properties:
> + rockchip,mic-in-differential:
> + type: boolean
> + description:
> + Describes if the microphone uses differential mode.
Your description copies property name. Do not describe the syntax
"Description describes", but say what is it.
> +
> allOf:
> - if:
> properties:
> @@ -284,5 +312,9 @@ examples:
> };
> };
> };
> +
> + rk809_codec: codec {
> + rockchip,mic-in-differential;
Missing all other properties. Make your example complete.
Best regards,
Krzysztof
