Am Freitag, 3. Mai 2024, 15:45:57 CEST schrieb Laurent Pinchart:
> On Fri, May 03, 2024 at 02:58:19PM +0200, Alexander Stein wrote:
> > Am Mittwoch, 17. April 2024, 11:12:04 CEST schrieb Alexander Stein:
> > > Am Dienstag, 16. April 2024, 16:19:10 CEST schrieb Marek Vasut:
> > > > Configure both CSI2 assigned-clock-rates the same way.
> > > > There does not seem to be any reason for keeping the
> > > > two CSI2 pixel clock set to different frequencies.
> > > >
> > > > This also reduces first CSI2 clock from overdrive mode
> > > > frequency which is 500 MHz down below the regular mode
> > > > frequency of 400 MHz.
> > > >
> > > > Signed-off-by: Marek Vasut <marex@xxxxxxx>
> > >
> > > Apparently there is no difference when using imx415 (3840x2160) sensor.
> >
> > Just for the records: While this change does not affect imx415 (3840x2160)
> > processing, reducing clock-frequency as well (v3) imx415 does not work.
> > So I assume that for this image size a higher than default frequency is
> > required.
>
> For the time being I expect sensor overlays to override the default
> clock setup.
Yep, that's what I did in the end.
> Ideally the clock frequencies should be configured
> automatically at runtime by the CSI-2 RX driver.
Ideally, yes. In this case it depends on whether it is MIPI-CSI 1 in normal
or overdrive mode, if it is MIPI-CSI 2 or if both cameras a run
simultaneously. I wonder if it really worth to add that much infrastructure
for a use case which is essentially fixed setup.
Best regards,
Alexander
> > > Reviewed-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> > >
> > > > ---
> > > > Cc: Conor Dooley <conor+dt@xxxxxxxxxx>
> > > > Cc: Fabio Estevam <festevam@xxxxxxxxx>
> > > > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> > > > Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > > > Cc: Paul Elder <paul.elder@xxxxxxxxxxxxxxxx>
> > > > Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> > > > Cc: Rob Herring <robh@xxxxxxxxxx>
> > > > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > > > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> > > > Cc: devicetree@xxxxxxxxxxxxxxx
> > > > Cc: imx@xxxxxxxxxxxxxxx
> > > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > > > ---
> > > > V2: Align both clock to 266 MHz and update commit message
> > > > ---
> > > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > > index 1bb96e96639f2..7883f5c056f4e 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > > > @@ -1667,7 +1667,7 @@ mipi_csi_0: csi@32e40000 {
> > > > <&clk IMX8MP_CLK_MEDIA_MIPI_PHY1_REF>;
> > > > assigned-clock-parents = <&clk IMX8MP_SYS_PLL2_1000M>,
> > > > <&clk IMX8MP_CLK_24M>;
> > > > - assigned-clock-rates = <500000000>;
> > > > + assigned-clock-rates = <266000000>;
> > > > power-domains = <&media_blk_ctrl IMX8MP_MEDIABLK_PD_MIPI_CSI2_1>;
> > > > status = "disabled";
> > > >
> > > >
>
>
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
