On Fri, May 03, 2024 at 06:35:53PM +0200, Stefan Eichenberger wrote: > On Thu, May 02, 2024 at 03:14:13PM +0100, Russell King (Oracle) wrote: > > On Thu, May 02, 2024 at 03:44:24PM +0200, Stefan Eichenberger wrote: > > > Hi Russell, > > > > > > Sorry for the late reply but I wanted to give you some update after > > > testing with the latest version of your patches on net-queue. > > > > I've also been randomly distracted, and I've been meaning to ping you > > to test some of the updates. > > > > http://git.armlinux.org.uk/cgit/linux-arm.git/log/?h=net-queue > > > > The current set begins with: > > > > "net: sfp-bus: constify link_modes to sfp_select_interface()" which is > > now in net-next, then the patches between and including: > > > > "net: phylink: validate sfp_select_interface() returned interface" to > > "net: phylink: clean up phylink_resolve()" > > > > That should get enough together for the PCS "neg" mode to be consistent > > with what the MAC driver sees. > > > > The remaining bits that I still need to sort out is the contents of > > phylink_pcs_neg_mode() for the 802.3z mode with PHY, and also working > > out some way of handling the SGMII case where the PHY and PCS disagree > > (one only supporting inband the other not supporting inband.) > > > > I'm not sure when I'll be able to get to that - things are getting > > fairly chaotic again, meaning I have again less time to spend on > > mainline... and I'd like to take some vacation time very soon (I really > > need some time off!) > > No problem, I'm also quite busy at the moment and I have the workaround > to test the hardware, so it is nothing urgent for me. > > > > I think I see the problem you are describing. > > > > > > When the driver starts it will negotiate MLO_AN_PHY based on the > > > capabilities of the PHY and of the PCS. However when I switch to 1GBit/s > > > it should switch to MLO_AN_INBAND but this does not work. Here the > > > output of phylink: > > > > I'm designing this to work the other way - inband being able to fall > > back to PHY (out of band) mode rather than PHY mode being able to fall > > forwards to inband mode. > > I tested again with 89e0a87ef79db9f3ce879e9d977429ba89ca8229 and I think > in my setup the problem is that it doesn't fall back to PHY mode but > takes it as default mode. Here what happens when I have the mxl-gpy PHY > connected to a 1000 GBit/s port: > [ 9.331179] mvpp2 f2000000.ethernet eth1: Using firmware node mac address 00:51:82:11:22:02 > [ 14.674836] mvpp2 f2000000.ethernet eth1: PHY f212a600.mdio-mii:11 doesn't supply possible interfaces > [ 14.674853] mvpp2 f2000000.ethernet eth1: interface 2 (mii) rate match none supports 0-3,6,13-14 > [ 14.674864] mvpp2 f2000000.ethernet eth1: interface 4 (sgmii) rate match none supports 0-3,5-6,13-14 > [ 14.674871] mvpp2 f2000000.ethernet eth1: interface 9 (rgmii) rate match none supports 0-3,5-6,13-14 > [ 14.674877] mvpp2 f2000000.ethernet eth1: interface 10 (rgmii-id) rate match none supports 0-3,5-6,13-14 > [ 14.674883] mvpp2 f2000000.ethernet eth1: interface 11 (rgmii-rxid) rate match none supports 0-3,5-6,13-14 > [ 14.674889] mvpp2 f2000000.ethernet eth1: interface 12 (rgmii-txid) rate match none supports 0-3,5-6,13-14 > [ 14.674895] mvpp2 f2000000.ethernet eth1: interface 22 (1000base-x) rate match none supports 5-6,13-14 > [ 14.674900] mvpp2 f2000000.ethernet eth1: interface 23 (2500base-x) rate match none supports 6,13-14,47 > [ 14.674907] mvpp2 f2000000.ethernet eth1: PHY [f212a600.mdio-mii:11] driver [Maxlinear Ethernet GPY215C] (irq=POLL) > [ 14.685444] mvpp2 f2000000.ethernet eth1: phy: 2500base-x setting supported 00,00000000,00008000,0000606f advertising 00,00000000,00008000,0000606f > [ 14.686635] mvpp2 f2000000.ethernet eth1: configuring for phy/2500base-x link mode > [ 14.694263] mvpp2 f2000000.ethernet eth1: major config, requested phy/2500base-x ^^^ You're still requesting (from firmware) for PHY mode, and phylink will _always_ use out-of-band if firmware requests that. > [ 14.700402] mvpp2 f2000000.ethernet eth1: major config, active phy/outband/2500base-x So it uses PHY mode for 2500base-X, which is correct. > [ 17.768370] mvpp2 f2000000.ethernet eth1: major config, requested phy/sgmii Still requesting PHY mode with SGMII, which historically we've always used out-of-band mode for, so we preserve that behaviour. > [ 17.774602] mvpp2 f2000000.ethernet eth1: firmware wants phy mode, but PHY requires inband So we complain about it with an error, because it is wrong... > [ 17.782976] mvpp2 f2000000.ethernet eth1: major config, active phy/outband/sgmii and we still try to use it (correctly, because that's what phylink has always done in this case.) As I tried to explain, there is fall-back from MLO_AN_INBAND to MLO_AN_PHY, but there won't be fall-forward from MLO_AN_PHY to MLO_AN_INBAND. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
