On Tue, Apr 16, 2024 at 7:05 AM Rob Herring <robh@xxxxxxxxxx> wrote: > On Fri, 12 Apr 2024 15:30:42 +0800, Chen-Yu Tsai wrote: > > The MediaTek MT7921S is a WiFi/Bluetooth combo chip that works over > > SDIO. WiFi and Bluetooth are separate SDIO functions within the chip. > > While the Bluetooth SDIO function is fully discoverable, the chip has > > a pin that can reset just the Bluetooth core, as opposed to the full > > chip. This should be described in the device tree. > > > > Add a device tree binding for the Bluetooth SDIO function of the MT7921S > > specifically to document the reset line. This binding is based on the MMC > > controller binding, which specifies one device node per SDIO function. > > > > Cc: Sean Wang <sean.wang@xxxxxxxxxxxx> > > Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> > > --- > > Changes since v2: > > - Expand description and commit message to clearly state that WiFi and > > Bluetooth are separate SDIO functions, and that each function should > > be a separate device node, as specified by the MMC binding. > > - Change 'additionalProperties' to 'unevaluatedProperties' > > - Add missing separating new line > > - s/ot/to/ > > > > Angelo's reviewed-by was not picked up due to the above changes. > > > > Changes since v1: > > - Reworded descriptions > > - Moved binding maintainer section before description > > - Added missing reference to bluetooth-controller.yaml > > - Added missing GPIO header to example > > --- > > .../bluetooth/mediatek,mt7921s-bluetooth.yaml | 55 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 56 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml > > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Luiz, could you pick up this patch? The other one is already merged in the MediaTek tree. Thanks! ChenYu