On 01/05/2024 13:17, Jeremy Kerr wrote:
> Hi Krzysztof,
>
>>> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
>>> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
>>> @@ -866,6 +866,13 @@ i2c: bus@1e78a000 {
>>> ranges = <0 0x1e78a000 0x1000>;
>>> };
>>>
>>> + i3c: bus@1e7a0000 {
>>> + compatible = "simple-bus";
>>
>> What bus is it? Why is it even needed? If it is i3c, then for sure
>> compatible is wrong.
>
> This is not the i3c bus, it's the MMIO mapping that allows us to specify
> the individual i3c controller mappings as sensible offsets into the main
> address space. Did you miss the ranges property there?
>
> This is following the existing design for the i2c controllers.
>
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges = <0 0x1e7a0000 0x8000>;
>>> + };
>>> +
>>> fsim0: fsi@1e79b000 {
>>> compatible = "aspeed,ast2600-fsi-master", "fsi-master";
>>> reg = <0x1e79b000 0x94>;
>>> @@ -1125,3 +1132,89 @@ i2c15: i2c-bus@800 {
>>> status = "disabled";
>>> };
>>> };
>>> +
>>> +&i3c {
>>
>> ????
>>
>> That's not how we construct DTS. Overrides/extends of nodes are for
>> boards, not within DTSI.
>
> The overrides are occurring at the &i3cX labels, not &i3c. Platform
> level dts just connect at those labels to define overrides for each bus:
You miss the point. Look how DTS is constructed, read DTS coding style.
Your first node is empty and that is not readable.
Best regards,
Krzysztof
