On 30.04.2024 9:54 AM, Krzysztof Kozlowski wrote: > On 29/04/2024 18:15, Marc Gonzalez wrote: >> Add YAML binding for Qualcomm MSM8998 Venus HW video encode and decode. >> (Based on qcom,msm8996-venus.yaml) >> >> Signed-off-by: Marc Gonzalez <mgonzalez@xxxxxxxxxx> >> --- [...] >> + >> + required: >> + - compatible >> + - clocks >> + - clock-names >> + - power-domains >> + >> + additionalProperties: false > > In nested blocks, put it after the type:object, for readability. > >> + > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> https://lore.kernel.org/linux-arm-msm/ba40de82-b308-67b1-5751-bb2d95f2b8a5@xxxxxxxxxx/ We've since established that the video-encoder/decoder subnodes are bogus Konrad