On 4/29/2024 8:59 AM, Rob Herring wrote: > On Mon, 22 Apr 2024 16:52:43 -0700, Oreoluwa Babatunde wrote: >> The __find_rmem() function is the only place that references the phandle >> field of the reserved_mem struct. __find_rmem() is used to match a >> device_node object to its corresponding entry in the reserved_mem array >> using its phandle value. But, there is already a function called >> of_reserved_mem_lookup() which carries out the same action using the >> name of the node. >> >> Using the of_reserved_mem_lookup() function is more reliable because >> every node is gauranteed to have a name, but not all nodes will have a >> phandle. >> >> Nodes are only assigned a phandle if they are explicitly defined in the >> DT using "phandle = <phandle_number>", or if they are referenced by >> another node in the DT. Hence, If the phandle field is empty, then >> __find_rmem() will return a false negative. >> >> Hence, delete the __find_rmem() function and switch to using the >> of_reserved_mem_lookup() function to find the corresponding entry of a >> device_node in the reserved_mem array. Since the phandle field of the >> reserved_mem struct is now unused, delete that as well. >> >> Signed-off-by: Oreoluwa Babatunde <quic_obabatun@xxxxxxxxxxx> >> --- >> drivers/of/of_reserved_mem.c | 26 +++----------------------- >> include/linux/of_reserved_mem.h | 1 - >> 2 files changed, 3 insertions(+), 24 deletions(-) >> > Applied, thanks! Thank you! >
