On 29/04/2024 13:15, Peter Griffin wrote: > + ufs_0: ufs@14700000 { > + compatible = "google,gs101-ufs"; > + reg = <0x14700000 0x200>, > + <0x14701100 0x200>, > + <0x14780000 0xa000>, > + <0x14600000 0x100>; > + reg-names = "hci", "vs_hci", "unipro", "ufsp"; > + interrupts = <GIC_SPI 532 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&cmu_hsi2 CLK_GOUT_HSI2_UFS_EMBD_I_ACLK>, > + <&cmu_hsi2 CLK_GOUT_HSI2_UFS_EMBD_I_CLK_UNIPRO>, > + <&cmu_hsi2 CLK_GOUT_HSI2_UFS_EMBD_I_FMP_CLK>, > + <&cmu_hsi2 CLK_GOUT_HSI2_QE_UFS_EMBD_HSI2_ACLK>, > + <&cmu_hsi2 CLK_GOUT_HSI2_QE_UFS_EMBD_HSI2_PCLK>, > + <&cmu_hsi2 CLK_GOUT_HSI2_SYSREG_HSI2_PCLK>; > + clock-names = "core_clk", "sclk_unipro_main", "fmp", > + "aclk", "pclk", "sysreg"; > + freq-table-hz = <0 0>, <0 0>, <0 0>, <0 0>, <0 0>, <0 0>; > + pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>; > + pinctrl-names = "default"; > + phys = <&ufs_0_phy>; > + phy-names = "ufs-phy"; > + samsung,sysreg = <&sysreg_hsi2 0x710>; > + status = "disabled"; > + }; > + > + ufs_0_phy: phy@0x14704000 { Drop 0x from unit address. Best regards, Krzysztof