Hi Krzysztof, On Sun, 28 Apr 2024 at 16:50, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 26/04/2024 15:38, Peter Griffin wrote: > > Add the ufs controller node and phy node for gs101. > > > > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx> > > Acked-by: André Draszik <andre.draszik@xxxxxxxxxx> > > --- > > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 36 ++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > > index 09044deede63..4679ca33c6a0 100644 > > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi > > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > > @@ -1277,6 +1277,42 @@ pinctrl_hsi2: pinctrl@14440000 { > > interrupts = <GIC_SPI 503 IRQ_TYPE_LEVEL_HIGH 0>; > > }; > > > > + ufs_0_phy: phy@17e04000 { > > + compatible = "google,gs101-ufs-phy"; > > + reg = <0x14704000 0x3000>; > > + reg-names = "phy-pma"; > > + samsung,pmu-syscon = <&pmu_system_controller>; > > + #phy-cells = <0>; > > + clocks = <&ext_24_5m>; > > + clock-names = "ref_clk"; > > + status = "disabled"; > > + }; > > + > > + ufs_0: ufs@14700000 { > > Unit-address order got broken here. Thanks for the review. Will fix regards, Peter