On 29/04/2024 12:16, Alina Yu wrote: > Since there is no way to check is ldo is adjustable or not. > 'richtek,use-fix-dvs' is added for that. user is supposed to know whether vout of ldo is adjustable. 1. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 2. Start sentences with capital letters. LDO is acronym. 3. Constraints already tell you that, don't they? Explain why they are not enough and you need new property. > > Signed-off-by: Alina Yu <alina_yu@xxxxxxxxxxx> > --- > .../devicetree/bindings/regulator/richtek,rtq2208.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml > index 609c066..3951679 100644 > --- a/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml > +++ b/Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml > @@ -75,6 +75,14 @@ properties: > description: > regulator description for ldo[1-2]. > > + properties: > + richtek,use-fix-dvs: > + type: boolean > + description: | > + ldo vout ability is determined by this setting. If it's set, the voltage is unadjustable. > + There is no risk-free method for software to determine whether the ldo vout is fixed or not. > + Therefore, it can only be done in this way. Wrap according to Linux style (as expressed in Linux coding style document). Best regards, Krzysztof
