Re: [PATCH net-next v4 09/12] net: ethernet: oa_tc6: implement receive path to receive rx ethernet frames

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ramon,

On 28/04/24 1:32 am, Ramón Nordin Rodriguez wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Could xfer.rx_buf for the data path point to the currently allocacted socket buff
>          struct spi_transfer xfer = { 0 };
>          struct spi_message msg;
> 
>          if (header_type == OA_TC6_DATA_HEADER) {
>                  xfer.tx_buf = tc6->spi_data_tx_buf;
>                  xfer.rx_buf = tc6->spi_data_rx_buf;
>          } else {
>                  xfer.tx_buf = tc6->spi_ctrl_tx_buf;
>                  xfer.rx_buf = tc6->spi_ctrl_rx_buf;
>          }
>          xfer.len = length;
> 
> To avoid an additional copy here?
I think, this can be done later as part of optimization/improvements. 
Let's keep it simple and optimize it later.

Best regards,
Parthiban V
> 
>> +static void oa_tc6_update_rx_skb(struct oa_tc6 *tc6, u8 *payload, u8 length)
>> +{
>> +     memcpy(skb_put(tc6->rx_skb, length), payload, length);
>> +}
>>
> 
> R
> 





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux