On Mon, Apr 29, 2024 at 2:18 PM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 27/04/2024 09:54, Jingbao Qiu wrote: > > Add YAML bindings for cv1800 spi nor controller. > > > > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx> > > --- > > .../bindings/spi/sophgo,spi-cv1800-nor.yaml | 33 +++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/spi/sophgo,spi-cv1800-nor.yaml > > > > diff --git a/Documentation/devicetree/bindings/spi/sophgo,spi-cv1800-nor.yaml b/Documentation/devicetree/bindings/spi/sophgo,spi-cv1800-nor.yaml > > new file mode 100644 > > index 000000000000..121a80fbf2d5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/spi/sophgo,spi-cv1800-nor.yaml > > Filename like compatible. > I will fix it. > > > @@ -0,0 +1,33 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/spi/sophgo,spi-cv1800-nor.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: SPI controller for Sophgo RISC-V SoCs > > + > > +maintainers: > > + - Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx> > > + > > +allOf: > > + - $ref: /schemas/spi/spi-controller.yaml# > > + > > +properties: > > + compatible: > > + const: sophgo,cv1800b-nor > > A bit unusual that compatible has nothing in common with tile of the > binding, thus the name of the hardware block. I will modify the title. > > > + > > + reg: > > + maxItems: 1 > > No clocks? No interrupts? This looks incomplete. If necessary, I will add clocks and interrupts. Thank you for your suggestion. Best regards, Jingbao Qiu
