On 28/04/2024 23:16, Ramón Nordin Rodriguez wrote: > From c65e42982684d5fd8b2294eb6acf755aa0fcab83 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Ram=C3=B3n=20Nordin=20Rodriguez?= > <ramon.nordin.rodriguez@xxxxxxxxxxx> > Date: Sun, 28 Apr 2024 22:25:12 +0200 > Subject: [PATCH net-next v4 13/12] net: lan865x: optional hardware reset > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > This commit optionally enables a hardware reset of the lan8650/1 > mac-phy. These chips have a software reset that is discourage from use > in the manual since it only resets the internal phy. > > Signed-off-by: Ramón Nordin Rodriguez <ramon.nordin.rodriguez@xxxxxxxxxxx> > --- > .../bindings/net/microchip,lan865x.yaml | 4 +++ > .../net/ethernet/microchip/lan865x/lan865x.c | 28 +++++++++++++++++++ Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof
