Hi Fabio On Fri, Apr 26, 2024 at 9:38 AM Fabio Aiuto <fabio.aiuto@xxxxxxxxxxx> wrote: > > i.Core MX93 is a NXP i.MX93 based SoM by Enigcam which needs to be > mounted on top of Engicam baseboards. > > Add support for EDIMM 2.0 Starter Kit hosting i.Core MX93. > > Starter Kit main features: > > 2x LVDS interfaces > HDMI output > Audio out > Mic in > Micro SD card slot > USB 3.0 A port > 3x USB 2.0 A port > Gb Ethernet > 2x CAN bus, 3x UART interfaces > SIM card slot > M.2 KEY_B slot > > Cc: Michael Nazzareno Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx> > Cc: Matteo Lisi <matteo.lisi@xxxxxxxxxxx> > Cc: Mirko Ardinghi <mirko.ardinghi@xxxxxxxxxxx> > Reviewed-by: Peng Fan <peng.fan@xxxxxxx> > Signed-off-by: Fabio Aiuto <fabio.aiuto@xxxxxxxxxxx> > --- Try to insert here the changelog in order people understand what was changed from V4 > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../dts/freescale/imx93-icore-mx93-edimm2.dts | 343 ++++++++++++++++++ > 2 files changed, 344 insertions(+) > create mode 100644 arch/arm64/boot/dts/freescale/imx93-icore-mx93-edimm2.dts > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 045250d0a040..d26c0a458a44 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -226,6 +226,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8qxp-mek.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8qxp-tqma8xqp-mba8xx.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8ulp-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx93-11x11-evk.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx93-icore-mx93-edimm2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx93-phyboard-segin.dtb > dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxca.dtb > dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx93-icore-mx93-edimm2.dts b/arch/arm64/boot/dts/freescale/imx93-icore-mx93-edimm2.dts > new file mode 100644 > index 000000000000..ff69decb8bd6 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx93-icore-mx93-edimm2.dts > @@ -0,0 +1,343 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2022 NXP > + * Copyright 2024 Engicam s.r.l. > + */ > + > +/dts-v1/; > + > +#include "imx93-icore-mx93.dtsi" > + > +/ { > + model = "Engicam i.Core MX93 - EDIMM 2 Starterkit"; > + compatible = "engicam,icore-mx93-edimm2", "engicam,icore-mx93", > + "fsl,imx93"; > + > + aliases { > + rtc1 = &bbnsm_rtc; > + }; > + > + chosen { > + stdout-path = &lpuart1; > + }; > + > + bt_reg_on: regulator-btregon { > + compatible = "regulator-gpio"; > + regulator-name = "BT_REG_ON"; > + regulator-min-microvolt = <100000>; > + regulator-max-microvolt = <3300000>; > + states = <3300000 0x1>, <100000 0x0>; > + gpios = <&gpio2 19 GPIO_ACTIVE_HIGH>; > + }; > + > + reg_1v8_sgtl: regulator-1v8-sgtl { > + compatible = "regulator-fixed"; > + regulator-name = "1v8_sgtl"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + }; > + > + reg_3v3_avdd_sgtl: regulator-3v3-avdd-sgtl { > + compatible = "regulator-fixed"; > + regulator-name = "3v3_avdd_sgtl"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + reg_3v3_sgtl: regulator-3v3-sgtl { > + compatible = "regulator-fixed"; > + regulator-name = "3v3_sgtl"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + linux,cma { > + compatible = "shared-dma-pool"; > + reusable; > + alloc-ranges = <0 0x80000000 0 0x40000000>; > + size = <0 0x10000000>; > + linux,cma-default; > + }; > + > + rsc_table: rsc-table@2021f000 { > + reg = <0 0x2021f000 0 0x1000>; > + no-map; > + }; > + > + vdevbuffer: vdevbuffer@a4020000 { > + compatible = "shared-dma-pool"; > + reg = <0 0xa4020000 0 0x100000>; > + no-map; > + }; > + > + vdev0vring0: vdev0vring0@a4000000 { > + reg = <0 0xa4000000 0 0x8000>; > + no-map; > + }; > + > + vdev0vring1: vdev0vring1@a4008000 { > + reg = <0 0xa4008000 0 0x8000>; > + no-map; > + }; > + > + vdev1vring0: vdev1vring0@a4000000 { > + reg = <0 0xa4010000 0 0x8000>; > + no-map; > + }; > + > + vdev1vring1: vdev1vring1@a4018000 { > + reg = <0 0xa4018000 0 0x8000>; > + no-map; > + }; > + }; > + > + sound { > + compatible = "simple-audio-card"; > + simple-audio-card,name = "imx93-sgtl5000"; > + simple-audio-card,format = "i2s"; > + simple-audio-card,bitclock-master = <&dailink_master>; > + simple-audio-card,frame-master = <&dailink_master>; > + /*simple-audio-card,mclk-fs = <1>;*/ > + > + simple-audio-card,cpu { > + sound-dai = <&sai3>; > + }; > + > + dailink_master: simple-audio-card,codec { > + sound-dai = <&sgtl5000>; > + clocks = <&clk IMX93_CLK_SAI3_IPG>; > + }; > + }; > + > + usdhc3_pwrseq: usdhc3-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usdhc3_pwrseq>; > + reset-gpios = <&gpio2 22 GPIO_ACTIVE_LOW>; > + }; > +}; > + > +&cm33 { > + mbox-names = "tx", "rx", "rxdb"; > + mboxes = <&mu1 0 1>, > + <&mu1 1 1>, > + <&mu1 3 1>; > + memory-region = <&vdevbuffer>, <&vdev0vring0>, <&vdev0vring1>, > + <&vdev1vring0>, <&vdev1vring1>, <&rsc_table>; > + status = "okay"; > +}; > + > +&flexcan1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flexcan1>; > + fsl,stop-mode = <&aonmix_ns_gpr 0x10 4>; > + status = "okay"; > +}; > + > +&flexcan2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flexcan2>; > + fsl,stop-mode = <&aonmix_ns_gpr 0x10 4>; > + status = "okay"; > +}; > + > +&lpi2c1 { > + #address-cells = <1>; > + #size-cells = <0>; > + clock-frequency = <400000>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&pinctrl_lpi2c1>; > + pinctrl-1 = <&pinctrl_lpi2c1>; > + status = "okay"; > + > + sgtl5000: audio-codec@a { > + compatible = "fsl,sgtl5000"; > + reg = <0x0a>; > + #sound-dai-cells = <0>; > + clocks = <&clk IMX93_CLK_SAI3_GATE>; > + VDDA-supply = <®_3v3_avdd_sgtl>; > + VDDIO-supply = <®_3v3_sgtl>; > + VDDD-supply = <®_1v8_sgtl>; > + status = "okay"; > + }; > + > + pcf8523: rtc@68 { > + compatible = "nxp,pcf8523"; > + reg = <0x68>; > + }; > +}; > + > +&lpuart1 { /* console */ > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart1>; > + status = "okay"; > +}; > + > +&lpuart5 { /* RS485 */ > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart5>; > + status = "okay"; > +}; Nit but nice to know how transceiver are driven > + > +&lpuart8 { /* RS232 */ > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart8>; > + status = "okay"; > +}; > + > +&micfil { > + #sound-dai-cells = <0>; > + assigned-clocks = <&clk IMX93_CLK_PDM>; > + assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>; > + assigned-clock-rates = <196608000>; > + status = "okay"; > +}; > + > +&mu1 { > + status = "okay"; > +}; > + > +&mu2 { > + status = "okay"; > +}; > + > +&sai1 { > + #sound-dai-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sai1>; > + assigned-clocks = <&clk IMX93_CLK_SAI1>; > + assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>; > + assigned-clock-rates = <12288000>; > + status = "okay"; > +}; > + Is this sai in use? If it's connected to the bluetooth then you need to keep not enable for now because seems unused and you don't declare a bt-sco sound device. As far I can see sai3->sgtl codec > +&sai3 { > + #sound-dai-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sai3>; > + assigned-clocks = <&clk IMX93_CLK_SAI3>; > + assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>; > + assigned-clock-rates = <24576000>; > + fsl,sai-mclk-direction-output; > + status = "okay"; > +}; > + > +&usdhc3 { /* WiFi */ > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default", "state_100mhz", "state_200mhz"; > + pinctrl-0 = <&pinctrl_usdhc3>; > + pinctrl-1 = <&pinctrl_usdhc3>; > + pinctrl-2 = <&pinctrl_usdhc3>; > + mmc-pwrseq = <&usdhc3_pwrseq>; > + bus-width = <4>; > + no-1-8-v; > + non-removable; > + max-frequency = <25000000>; > + status = "okay"; > + > + brcmf: bcrmf@1 { > + compatible = "brcm,bcm4329-fmac"; > + reg = <1>; > + }; > +}; > + > +&wdog3 { > + status = "okay"; > +}; > + > +&iomuxc { > + pinctrl_bluetooth: bluetoothgrp { > + fsl,pins = < > + MX93_PAD_GPIO_IO19__GPIO2_IO19 0x31e /* BT_REG_ON */ > + >; > + }; > + > + pinctrl_flexcan1: flexcan1grp { > + fsl,pins = < > + MX93_PAD_PDM_CLK__CAN1_TX 0x139e > + MX93_PAD_PDM_BIT_STREAM0__CAN1_RX 0x139e > + >; > + }; > + > + pinctrl_flexcan2: flexcan2grp { > + fsl,pins = < > + MX93_PAD_GPIO_IO25__CAN2_TX 0x139e > + MX93_PAD_GPIO_IO27__CAN2_RX 0x139e > + >; > + }; > + > + pinctrl_lpi2c1: lpi2c1grp { > + fsl,pins = < > + MX93_PAD_I2C1_SCL__LPI2C1_SCL 0x40000b9e > + MX93_PAD_I2C1_SDA__LPI2C1_SDA 0x40000b9e > + >; > + }; > + > + pinctrl_sai1: sai1grp { > + fsl,pins = < > + MX93_PAD_SAI1_TXC__SAI1_TX_BCLK 0x31e > + MX93_PAD_SAI1_TXFS__SAI1_TX_SYNC 0x31e > + MX93_PAD_SAI1_TXD0__SAI1_TX_DATA00 0x31e > + MX93_PAD_SAI1_RXD0__SAI1_RX_DATA00 0x31e > + >; > + }; > + > + pinctrl_sai3: sai3grp { > + fsl,pins = < > + MX93_PAD_GPIO_IO26__SAI3_TX_SYNC 0x31e > + MX93_PAD_GPIO_IO16__SAI3_TX_BCLK 0x31e > + MX93_PAD_GPIO_IO17__SAI3_MCLK 0x31e > + MX93_PAD_GPIO_IO21__SAI3_TX_DATA00 0x31e > + MX93_PAD_GPIO_IO20__SAI3_RX_DATA00 0x31e > + >; > + }; > + > + pinctrl_uart1: uart1grp { > + fsl,pins = < > + MX93_PAD_UART1_RXD__LPUART1_RX 0x31e > + MX93_PAD_UART1_TXD__LPUART1_TX 0x31e > + >; > + }; > + > + pinctrl_uart5: uart5grp { > + fsl,pins = < > + MX93_PAD_GPIO_IO01__LPUART5_RX 0x31e > + MX93_PAD_GPIO_IO00__LPUART5_TX 0x31e > + MX93_PAD_GPIO_IO02__LPUART5_CTS_B 0x31e > + MX93_PAD_GPIO_IO03__LPUART5_RTS_B 0x31e > + >; > + }; > + > + pinctrl_uart8: uart8grp { > + fsl,pins = < > + MX93_PAD_GPIO_IO13__LPUART8_RX 0x31e > + MX93_PAD_GPIO_IO12__LPUART8_TX 0x31e > + >; > + }; > + > + pinctrl_usdhc3: usdhc3grp { > + fsl,pins = < > + MX93_PAD_SD3_CLK__USDHC3_CLK 0x17fe > + MX93_PAD_SD3_CMD__USDHC3_CMD 0x13fe > + MX93_PAD_SD3_DATA0__USDHC3_DATA0 0x13fe > + MX93_PAD_SD3_DATA1__USDHC3_DATA1 0x13fe > + MX93_PAD_SD3_DATA2__USDHC3_DATA2 0x13fe > + MX93_PAD_SD3_DATA3__USDHC3_DATA3 0x13fe > + >; > + }; > + > + pinctrl_usdhc3_pwrseq: usdhc3pwrseqgrp { > + fsl,pins = < > + MX93_PAD_GPIO_IO22__GPIO2_IO22 0x31e /* WL_REG_ON */ > + >; > + }; > +}; > -- > 2.34.1 With this changes: Reviewed-by: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx> > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 michael@xxxxxxxxxxxxxxxxxxxx __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 info@xxxxxxxxxxxxxxxxxxxx www.amarulasolutions.com