Hi Andrew, On 24/04/24 4:56 am, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> +static int oa_tc6_read_status0(struct oa_tc6 *tc6) >> +{ >> + u32 regval; >> + int ret; >> + >> + ret = oa_tc6_read_register(tc6, OA_TC6_REG_STATUS0, ®val); >> + if (ret) >> + return 0; > > If there is an error, your throw the error code away? > > It is a bit messy, since you are using this inside > readx_poll_timeout(). I would probably do a netdev_warn() or similar, > since it should not happen, and then return 0? I _think_ this is > probably the first bus transaction we do, so if it fails, knowing the > error code will help figuring out what is wrong with the SPI bus > configuration. OK, I will add the below print before "return 0;" in the next version. dev_err(&tc6->spi->dev, "STATUS0 register read failed: %d\n", ret); Best regards, Parthiban V > > Andrew >