On Wed, Apr 24, 2024 at 08:22:46PM +0200, Marek Behún wrote: > On Wed, 24 Apr 2024 13:16:18 -0500 > Rob Herring <robh@xxxxxxxxxx> wrote: > > > On Wed, 24 Apr 2024 19:38:00 +0200, Marek Behún wrote: > > > Add binding for cznic,turris-omnia-mcu, the device-tree node > > > representing the system-controller features provided by the MCU on the > > > Turris Omnia router. > > > > > > Signed-off-by: Marek Behún <kabel@xxxxxxxxxx> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > --- > > > .../firmware/cznic,turris-omnia-mcu.yaml | 86 +++++++++++++++++++ > > > MAINTAINERS | 1 + > > > 2 files changed, 87 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/firmware/cznic,turris-omnia-mcu.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/firmware/cznic,turris-omnia-mcu.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename > > $id: http://devicetree.org/schemas/arm/cznic,turris-omnia-mcu.yaml > > file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/firmware/cznic,turris-omnia-mcu.yaml > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240424173809.7214-2-kabel@xxxxxxxxxx > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit after running the above command yourself. Note > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > your schema. However, it must be unset to test all examples with your schema. > > > > Sigh. I moved the patch bud did not change it in $id... A bit needless, given you've got a tag from Krzysztof, but with that fixed Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
