On 25/04/2024 10:16, Krzysztof Kozlowski wrote: > On 25/04/2024 11:15, Niko Pasaloukos wrote: >> Add device tree bindings for the Blaize BLZP1600 CB2 >> development board (carrier board), which uses the >> BLZP1600 SoM. >> >> Reviewed-by: James Cowgill <james.cowgill@xxxxxxxxxx> >> Reviewed-by: Matt Redfearn <matt.redfearn@xxxxxxxxxx> >> Reviewed-by: Neil Jones <neil.jones@xxxxxxxxxx> >> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@xxxxxxxxxx> >> --- >> .../devicetree/bindings/arm/blaize.yaml | 40 +++++++++++++++++++ >> 1 file changed, 40 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/blaize.yaml >> >> diff --git a/Documentation/devicetree/bindings/arm/blaize.yaml b/Documentation/devicetree/bindings/arm/blaize.yaml >> new file mode 100644 >> index 000000000000..8034aeb7a2b4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/blaize.yaml >> @@ -0,0 +1,40 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/arm/blaize.yaml*__;Iw!!FddXBOku!i6XKbnL3gXmoklJKfuksrfCB61MTEFuw8JiIVn9sS0CzEmHpqDhXguC5Me3sUQt1gw4RxA4mo8TAHR8psxBV0Dmrs0veWKlRgo18$ >> +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!FddXBOku!i6XKbnL3gXmoklJKfuksrfCB61MTEFuw8JiIVn9sS0CzEmHpqDhXguC5Me3sUQt1gw4RxA4mo8TAHR8psxBV0Dmrs0veWEVjMhqf$ >> + >> +title: Blaize Platforms >> + >> +maintainers: >> + - James Cowgill <james.cowgill@xxxxxxxxxx> >> + - Matt Redfearn <matt.redfearn@xxxxxxxxxx> >> + - Neil Jones <neil.jones@xxxxxxxxxx> >> + - Nikolaos Pasaloukos <nikolaos.pasaloukos@xxxxxxxxxx> >> + >> +description: | >> + Blaize Platforms using SoCs designed by Blaize Inc. >> + >> + The products currently based on the BLZP1600 SoC: >> + >> + - BLZP1600-SoM: SoM module >> + - BLZP1600-CB2: Development board CB2 based on BLZP1600-SoM >> + >> + The compatible property should follow the format: >> + >> + compatible = "blaize,blzp1600-cb2", "blaize,blzp1600"; > > This is a friendly reminder during the review process. > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion and > either implement all requested changes or keep discussing them. > > Thank you. > > Best regards, > Krzysztof > Apologies, you are right. Now with the threading fixed, I'll be able to gather all the feedback properly. I'll fix this on V4. Best regards, Niko
