On Wed, 24 Apr 2024 23:09:47 +1200 Ryan Walklin <ryan@xxxxxxxxxxxxx> wrote: > The RG35XX-H adds thumbsticks, a stereo speaker, and a second USB port to the RG35XX-Plus, and has a horizontal form factor. > > Enabled in this DTS: > - Thumbsticks > - Second USB port > > Signed-off-by: Ryan Walklin <ryan@xxxxxxxxxxxxx> > --- > Changelog v1..v2: > - Update copyright > - Spaces -> Tabs > - Add GP ADC joystick axes and mux [1] > - Add EHCI/OHCI1 for second USB port and add vbus supply > > Changelog v2..v3: > - Add DTB to Makefile > - Remove USB vbus supply > - Remove GPADC joysticks until required patches land [1] > - Move thumbsticks into existing gpio gamepad node > - Move changelog and links below fold-line > > [1]: https://lore.kernel.org/linux-sunxi/20240417170423.20640-1-macroalpha82@xxxxxxxxx/T/#t > > --- > arch/arm64/boot/dts/allwinner/Makefile | 1 + > .../sun50i-h700-anbernic-rg35xx-h.dts | 46 +++++++++++++++++++ > 2 files changed, 47 insertions(+) > create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-h.dts > > diff --git a/arch/arm64/boot/dts/allwinner/Makefile b/arch/arm64/boot/dts/allwinner/Makefile > index 4217328b1889..c2c871d8b71e 100644 > --- a/arch/arm64/boot/dts/allwinner/Makefile > +++ b/arch/arm64/boot/dts/allwinner/Makefile > @@ -49,3 +49,4 @@ dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-orangepi-zero3.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h618-transpeed-8k618-t.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-2024.dtb > dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-plus.dtb > +dtb-$(CONFIG_ARCH_SUNXI) += sun50i-h700-anbernic-rg35xx-h.dtb > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-h.dts b/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-h.dts > new file mode 100644 > index 000000000000..3f4435ff9b71 > --- /dev/null > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-h.dts > @@ -0,0 +1,46 @@ > +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +/* > + * Copyright (C) 2024 Ryan Walklin <ryan@xxxxxxxxxxxxx>. > + * Copyright (C) 2024 Chris Morgan <macroalpha82@xxxxxxxxx>. > + */ > + > +#include "sun50i-h700-anbernic-rg35xx-plus.dts" > + > +/ { > + model = "Anbernic RG35XX H"; > + compatible = "anbernic,rg35xx-h", "allwinner,sun50i-h700"; > +}; > + > +&gpio_keys_gamepad { > + > + button-thumbl { > + label = "GPIO Thumb Left"; > + gpios = <&pio 4 8 GPIO_ACTIVE_LOW>; /* PE8 */ > + linux,input-type = <EV_KEY>; > + linux,code = <BTN_THUMBL>; > + }; > + > + button-thumbr { > + label = "GPIO Thumb Right"; > + gpios = <&pio 4 9 GPIO_ACTIVE_LOW>; /* PE9 */ > + linux,input-type = <EV_KEY>; > + linux,code = <BTN_THUMBR>; > + }; > +}; > + > +&ehci1 { > + status = "okay"; > +}; > + > +&ohci1 { > + status = "okay"; > +}; > + > +&usbotg { > + dr_mode = "peripheral"; > + status = "okay"; > +}; > + > +&usbphy { > + status = "okay"; > +}; Those two nodes look redundant, since they exist already in the base .dts. I guess &usbphy needs to be adjusted later, but &usbotg is likely to stay the same? Anyway, it doesn't really hurt, so: Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx> Cheers, Andre
