On 4/24/24 15:04, Rob Herring wrote:
On Wed, Apr 24, 2024 at 11:04:52AM +0200, Peter Korsgaard wrote:
Similar to target-rpm from fan-common.yaml but for the PWM setting
(0..255).
IIRC, we have a map of RPMs to PWM duty cycle, so why can't you
use that plus target-rpm?
target-rpm is the target fan speed. The property defined here
is the default pwm to set when the device is instantiated.
The two values are also orthogonal. The fan rpm is fan dependent.
Each fan will require a different pwm value to reach the target speed.
Trying to use target-rpm to set a default pwm value would really
not make much if any sense.
Guenter
Anything new for existing fan bindings should ideally use what
fan-common.yaml defined or be added to it.
Signed-off-by: Peter Korsgaard <peter@xxxxxxxxxxxxx>
---
Documentation/devicetree/bindings/hwmon/pwm-fan.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
index 4e5abf7580cc..58513ff732af 100644
--- a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml
@@ -46,6 +46,14 @@ properties:
"#cooling-cells": true
+ target-pwm:
+ description:
+ The default desired fan PWM.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 255
+ default: 255
+
required:
- compatible
- pwms
--
2.39.2
