On 24/04/2024 15:32, Niko Pasaloukos wrote: > Add SCMI clock numbers according to the Blaize BLZP1600 > SoC hardware specifications. > > Reviewed-by: James Cowgill <james.cowgill@xxxxxxxxxx> > Reviewed-by: Matt Redfearn <matt.redfearn@xxxxxxxxxx> > Reviewed-by: Neil Jones <neil.jones@xxxxxxxxxx> > Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@xxxxxxxxxx> This goes to the patch introducing binding doc. > --- > .../dt-bindings/clock/blaize,blzp1600-clk.h | 77 +++++++++++++++++++ > 1 file changed, 77 insertions(+) > create mode 100644 include/dt-bindings/clock/blaize,blzp1600-clk.h > > diff --git a/include/dt-bindings/clock/blaize,blzp1600-clk.h b/include/dt-bindings/clock/blaize,blzp1600-clk.h > new file mode 100644 > index 000000000000..f1d59849a6e5 > --- /dev/null > +++ b/include/dt-bindings/clock/blaize,blzp1600-clk.h > @@ -0,0 +1,77 @@ > +/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */ > +/* > + * Copyright (C) 2023, Blaize, Inc. > + */ > + > +#ifndef DT_BINDING_CLK_BLZP1600_H > +#define DT_BINDING_CLK_BLZP1600_H > + > +/* ARM SCMI clocks */ > + > +/* BLZP1600 clock-gate numbers as defined in the hardware architecture */ > + > +#define BLZP1600_CPU_CLK 0 > +/* clock-gates 1-6 invalid */ No, they cannot be invalid. IDs start from 0 and are incremented by one. If you have holes, it is not a binding. Drop the header or use it properly, so as virtual IDs. Best regards, Krzysztof
